Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix simple reading with accessors fetching #12000

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix simple reading with accessors fetching #12000

merged 2 commits into from
Nov 27, 2024
+67 −43

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

⚪ 2024-11-26 11:39:13 UTC Pre-commit check linux-x86_64-release-asan for 18f84a6 has started.
⚪ 2024-11-26 11:39:24 UTC Artifacts will be uploaded here
⚪ 2024-11-26 11:42:17 UTC ya make is running...
🟡 2024-11-26 13:02:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8988 8925 0 13 5 45

🟢 2024-11-26 13:03:02 UTC Build successful.
🟢 2024-11-26 13:03:32 UTC ydbd size 4.9 GiB changed* by +69.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2a7eb6b merge: 18f84a6 diff diff %
ydbd size 5 293 729 296 Bytes 5 293 800 816 Bytes +69.8 KiB +0.001%
ydbd stripped size 1 361 387 440 Bytes 1 361 400 560 Bytes +12.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

⚪ 2024-11-26 11:39:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 18f84a6 has started.
⚪ 2024-11-26 11:40:04 UTC Artifacts will be uploaded here
⚪ 2024-11-26 11:42:58 UTC ya make is running...
🟢 2024-11-26 12:33:18 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15211 13705 0 0 1395 111

🟢 2024-11-26 12:34:32 UTC Build successful.
🟢 2024-11-26 12:34:48 UTC ydbd size 2.5 GiB changed* by +36.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6ed5294 merge: 18f84a6 diff diff %
ydbd size 2 694 567 960 Bytes 2 694 605 784 Bytes +36.9 KiB +0.001%
ydbd stripped size 482 592 400 Bytes 482 598 608 Bytes +6.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

⚪ 2024-11-26 13:52:47 UTC Pre-commit check linux-x86_64-release-asan for 3784a6b has started.
⚪ 2024-11-26 13:52:51 UTC Artifacts will be uploaded here
⚪ 2024-11-26 13:55:45 UTC ya make is running...
🟡 2024-11-26 14:57:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8997 8913 0 17 20 47

🟢 2024-11-26 14:58:20 UTC Build successful.
🟡 2024-11-26 14:58:46 UTC ydbd size 4.9 GiB changed* by +123.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4d29f0f merge: 3784a6b diff diff %
ydbd size 5 293 729 296 Bytes 5 293 856 000 Bytes +123.7 KiB +0.002%
ydbd stripped size 1 361 387 440 Bytes 1 361 402 416 Bytes +14.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

⚪ 2024-11-26 13:53:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3784a6b has started.
⚪ 2024-11-26 13:53:42 UTC Artifacts will be uploaded here
⚪ 2024-11-26 13:56:36 UTC ya make is running...
🟢 2024-11-26 14:43:43 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15219 13713 0 0 1396 110

🟢 2024-11-26 14:44:58 UTC Build successful.
🟢 2024-11-26 14:45:15 UTC ydbd size 2.5 GiB changed* by +52.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4d29f0f merge: 3784a6b diff diff %
ydbd size 2 694 580 984 Bytes 2 694 635 008 Bytes +52.8 KiB +0.002%
ydbd stripped size 482 594 640 Bytes 482 599 376 Bytes +4.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

zverevgeny
zverevgeny previously approved these changes Nov 27, 2024
View reviewed changes
@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review November 27, 2024 06:59
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner November 27, 2024 06:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 07:05:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 76aa988 has started.
⚪ 2024-11-27 07:06:10 UTC Artifacts will be uploaded here
⚪ 2024-11-27 07:09:14 UTC ya make is running...
🟢 2024-11-27 08:26:16 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20537 19025 0 0 1398 114

🟢 2024-11-27 08:27:54 UTC Build successful.
🟢 2024-11-27 08:28:12 UTC ydbd size 2.5 GiB changed* by +80.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 40b58a4 merge: 76aa988 diff diff %
ydbd size 2 694 101 816 Bytes 2 694 184 104 Bytes +80.4 KiB +0.003%
ydbd stripped size 482 087 952 Bytes 482 096 208 Bytes +8.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 07:06:03 UTC Pre-commit check linux-x86_64-release-asan for 76aa988 has started.
⚪ 2024-11-27 07:06:14 UTC Artifacts will be uploaded here
⚪ 2024-11-27 07:09:25 UTC ya make is running...
🟡 2024-11-27 08:46:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13053 12973 0 21 15 44

🟢 2024-11-27 08:47:37 UTC Build successful.
🟡 2024-11-27 08:48:03 UTC ydbd size 4.9 GiB changed* by +190.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 40b58a4 merge: 76aa988 diff diff %
ydbd size 5 293 078 656 Bytes 5 293 273 288 Bytes +190.1 KiB +0.004%
ydbd stripped size 1 360 778 416 Bytes 1 360 815 152 Bytes +35.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 merged commit bbdc254 into ydb-platform:main Nov 27, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_simple_reading branch November 27, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalrus1 swalrus1 swalrus1 approved these changes

@zverevgeny zverevgeny zverevgeny left review comments

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanmorozov333 @swalrus1 @zverevgeny